Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libparsec] generate_new_device is too broad and should be replaced by usage-specifc methods #8790

Open
AureliaDolo opened this issue Oct 25, 2024 · 1 comment

Comments

@AureliaDolo
Copy link
Contributor

AureliaDolo commented Oct 25, 2024

I think this generate_new_device is too broad and we should instead replace it with multiple methods, each dedicated to a narrow usecase (especially since it naming is error prone, as we don't know if it means a new device for an existing or for a new user ^^).

from_existing_device_for_user is a good step in that direction (though I would rename this new_device_for_user)

So we can also add new_user that should be use when creating the first device for a user.

What do you think ?

Originally posted by @touilleMan in #8585 (comment)

@AureliaDolo
Copy link
Contributor Author

  • recovery device
  • claim device
  • bootstrap organization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant