Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The manifest returned by merge_local_folder_manifest is sometimes incorrectly need_sync #8750

Open
vxgmichel opened this issue Oct 17, 2024 · 0 comments
Labels
A-Client Area: Parsec desktop application I-Rust Impact: Rust-related stuff

Comments

@vxgmichel
Copy link
Contributor

The manifest returned by merge_local_folder_manifest should always be need_sync=False when its content matches the remote, which is not the case at the moment (specifically when the manifest comes from ourselves),

Here's a commit referencing this issue: 863f524

Also, add a test corresponding to this case:

  • A change is made locally
  • The app uploads the corresponding manifest
  • The app is closed before it could acknowledge the upload
  • The app start again, performing an inbound sync on the freshly uploaded manifest
  • Check that the merge produced a local manifest with need_sync=False in order to avoid a new inbound sync
@vxgmichel vxgmichel changed the title The manifest return by merge_local_folder_manifest is sometimes incorrectly need_sync The manifest returned by merge_local_folder_manifest is sometimes incorrectly need_sync Oct 17, 2024
@FirelightFlagboy FirelightFlagboy added I-Rust Impact: Rust-related stuff A-Client Area: Parsec desktop application labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application I-Rust Impact: Rust-related stuff
Projects
None yet
Development

No branches or pull requests

2 participants