Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device model to include a type field #8748

Open
FirelightFlagboy opened this issue Oct 17, 2024 · 1 comment
Open

Update device model to include a type field #8748

FirelightFlagboy opened this issue Oct 17, 2024 · 1 comment
Labels
A-Client Area: Parsec desktop application I-Data Impact: data used to persist information I-Rust Impact: Rust-related stuff

Comments

@FirelightFlagboy
Copy link
Contributor

We have multiple device type, and are working to introduce some more:

  • Standard device
  • Recovery device
  • Shamir device
  • Parsec Auth device

We would like to be able to differentiate the types of device.

We could add a field (like type) to identify the type of device.

Currently we rely on the untagged deserialization provided by serde to load each device type but we would like to provide that information upfront to the lib user.

Adding a type field, would also make serde more efficient at deserializing the devices since it can directly identify the type of device.

@FirelightFlagboy FirelightFlagboy added A-Client Area: Parsec desktop application I-Rust Impact: Rust-related stuff I-Data Impact: data used to persist information labels Oct 17, 2024
@FirelightFlagboy
Copy link
Contributor Author

This concern the device certificate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application I-Data Impact: data used to persist information I-Rust Impact: Rust-related stuff
Projects
None yet
Development

No branches or pull requests

1 participant