Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ToS acceptance via CLI #8664

Open
1 of 4 tasks
mmmarcos opened this issue Oct 8, 2024 · 0 comments
Open
1 of 4 tasks

Implement ToS acceptance via CLI #8664

mmmarcos opened this issue Oct 8, 2024 · 0 comments
Assignees
Labels
enhancement Improve functionality, potentially changing behavior I-CLI Impact: Command-line interface I-Rust Impact: Rust-related stuff

Comments

@mmmarcos
Copy link
Contributor

mmmarcos commented Oct 8, 2024

The CLI-based workflow described in #7847 needs to be able to work on a server requesting ToS acceptance (introduced in #6439).

Some ideas on how to achieve this (to be discussed):

  • CLI "auto-accept-tos" option added to each command
  • CLI "auto-accept-tos" mode via configuration or envvar

In either cases, the workflow would be something like:

  1. CLI runs command X
  2. Server respond "ToS acceptance required"
  3. CLI sends ToS acceptance
  4. CLI retry command X

Notes:

  • Only implementing CLI commands for getting/accept ToS is not sufficient because it should be possible to automate the process (thus the auto accept option or mode).
  • Also, exposing commands for getting/accept ToS is not strictly required either because this could be transparently implemented as a behavior of the CLI (enabled via envvar) instead of commands available for the user. This could be done later.

TODOs

@mmmarcos mmmarcos added enhancement Improve functionality, potentially changing behavior I-Rust Impact: Rust-related stuff I-CLI Impact: Command-line interface labels Oct 8, 2024
@mmmarcos mmmarcos changed the title Implement T&C acceptance via CLI Implement ToS acceptance via CLI Oct 8, 2024
@FirelightFlagboy FirelightFlagboy self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve functionality, potentially changing behavior I-CLI Impact: Command-line interface I-Rust Impact: Rust-related stuff
Projects
None yet
Development

No branches or pull requests

2 participants