Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common metadata operations on split-attributes #5444

Closed
pp-mo opened this issue Aug 22, 2023 · 2 comments · Fixed by #5538
Closed

Common metadata operations on split-attributes #5444

pp-mo opened this issue Aug 22, 2023 · 2 comments · Fixed by #5538
Assignees

Comments

@pp-mo
Copy link
Member

pp-mo commented Aug 22, 2023

As mentioned in #5410

This is about common-metadata operations : equal(compare) / difference / combine, as they apply to CubeMetadata, where the attributes properties are new-style "split" attribute dictionaries.

The #5410 PR provides that the new cube.attributes "CubeAttrsDict" can stand in for the legacy LimitedAttributeDicts where required, with a particular equivalence to the single dict form. Thus, everything using common metadata will still "work",i.e. not fail.

But @trexfeathers pointed out that we might want different behaviours, specific to split dictionaries.
For example, do we consider cube metadata equal if their atributes are CubeAttrsDict(globals={'x':1}) and CubeAttrsDict(locals={'x':1})? These are equivalent, when treated as single "combined" dictionaries, but that is probably not how we want the operation to work.

The basis of a possible solution is suggested here.

@pp-mo pp-mo converted this from a draft issue Aug 22, 2023
@pp-mo
Copy link
Member Author

pp-mo commented Aug 24, 2023

See pp-mo#77

I am happy now + ready to propose that this provides an appropriate solution.
To become an Iris PR once #5410 is in, as it is based on that code + will need rebasing.

@pp-mo pp-mo moved this from Todo to In Progress in Split cube-attrs project Aug 24, 2023
@pp-mo pp-mo self-assigned this Aug 30, 2023
@pp-mo pp-mo linked a pull request Oct 10, 2023 that will close this issue
@pp-mo pp-mo moved this from In Progress to Ready / In Review in Split cube-attrs project Oct 10, 2023
@pp-mo
Copy link
Member Author

pp-mo commented Nov 15, 2023

Closed by #5538

@pp-mo pp-mo closed this as completed Nov 15, 2023
@pp-mo pp-mo moved this from Ready / In Review to Done in Split cube-attrs project Nov 15, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant