-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common metadata operations on split-attributes #5444
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #5410
This is about common-metadata operations : equal(compare) / difference / combine, as they apply to CubeMetadata, where the attributes properties are new-style "split" attribute dictionaries.
The #5410 PR provides that the new cube.attributes "CubeAttrsDict" can stand in for the legacy LimitedAttributeDicts where required, with a particular equivalence to the single dict form. Thus, everything using common metadata will still "work",i.e. not fail.
But @trexfeathers pointed out that we might want different behaviours, specific to split dictionaries.
For example, do we consider cube metadata equal if their atributes are
CubeAttrsDict(globals={'x':1})
andCubeAttrsDict(locals={'x':1})
? These are equivalent, when treated as single "combined" dictionaries, but that is probably not how we want the operation to work.The basis of a possible solution is suggested here.
The text was updated successfully, but these errors were encountered: