Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the implications of adopting NEP29? #4369

Open
1 of 6 tasks
jamesp opened this issue Oct 13, 2021 · 7 comments
Open
1 of 6 tasks

What are the implications of adopting NEP29? #4369

jamesp opened this issue Oct 13, 2021 · 7 comments
Labels
Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton

Comments

@jamesp
Copy link
Member

jamesp commented Oct 13, 2021

  • Review iris top-level dependencies for their NEP29 position
  • How would we implement? e.g. minimum pins
  • Document as part of the release manager process
  • Is there a NEP29 bot or tooling to help us?
  • What is our view on other package min versions? 24 or 42 months? those with erratic release schedules?
  • How do we communicate iris adopting NEP29? Internally at Met Office and externally as open source project
@jamesp jamesp added New: Issue Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton labels Oct 13, 2021
@jamesp
Copy link
Member Author

jamesp commented Oct 13, 2021

Communication:

  • Python Guild presentation
  • VATools representatives to help us communicate

@pp-mo
Copy link
Member

pp-mo commented Oct 18, 2021

@jamesp Should this be converted into a discussion?
Can also maybe link to 3.2.x release discussion

@jamesp
Copy link
Member Author

jamesp commented Oct 18, 2021

There is a discussion for this: #4332. This list of actions was written at the end of our peloton on 2021-10-13 to capture the specific actions we would like to address before adopting NEP29. If an item requires substantial work the list could be refined into individual issue items by those who would like to tackle them.

@wjbenfold
Copy link
Contributor

Python core dependency views on NEP29:

Doing it:

No indication from a fairly quick google:

  • cf-units (is this us?)
  • cf-time (is this too?)
  • netcdf4
  • python-xxhash

@jamesp
Copy link
Member Author

jamesp commented Oct 19, 2021

Thanks @wjbenfold, first item on the list ticked off!

@trexfeathers
Copy link
Contributor

cf-units (is this us?)

Yes

cf-time (is this too?)

No

@rcomer
Copy link
Member

rcomer commented Oct 30, 2021

My reading of this

support at least all minor versions of Python introduced and released in the prior 42 months from the anticipated release date

is that we should be supporting all python versions newer than python3.7*. So getting the tests working with 3.9 and 3.10 should be priority.

*Since our anticipated release date for Iris3.2 is January (#4129) python3.7 will have fallen out of the 42 month window by release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton
Projects
Status: No status
Development

No branches or pull requests

5 participants