Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery: wind plot missing lake features #4110

Closed
rcomer opened this issue Apr 29, 2021 · 4 comments · Fixed by #4112 or #4108
Closed

Gallery: wind plot missing lake features #4110

rcomer opened this issue Apr 29, 2021 · 4 comments · Fixed by #4112 or #4108

Comments

@rcomer
Copy link
Member

rcomer commented Apr 29, 2021

📚 Documentation

The Plotting Wind Direction Using Quiver example uses NaturalEarth to add lake outlines. But those outlines don't actually show up in the displayed plots. It looks like they disappeared at Iris 2.1:

@rcomer
Copy link
Member Author

rcomer commented Apr 29, 2021

grep confirms that this is the only example that uses cartopy.feature

@rcomer
Copy link
Member Author

rcomer commented Apr 29, 2021

Running this example locally:

  • I do not get the lake outlines with Iris3.0.1 (default-next).
  • I do get the lake outlines with my iris-dev environment, which still has Cartopy 0.18. Also the gallerytest fails.

@rcomer
Copy link
Member Author

rcomer commented Apr 29, 2021

There were some changes to edgecolor handling for Matplotlib v3.4: https://matplotlib.org/stable/users/whats_new.html#collection-color-specification-and-mapping

So I think the gallery example is fixed, but we need to update the reference imagehash.

@jamesp
Copy link
Member

jamesp commented Apr 29, 2021

@rcomer agree, editing the gallery test file I see the same. the outlines are in my dev version, if I comment out ax.add_feature(lakes) the test will pass.

Agree the thing to do here is add the new image hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants