Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iris.plot arguments #4085

Closed
rcomer opened this issue Apr 8, 2021 · 4 comments · Fixed by #4100
Closed

iris.plot arguments #4085

rcomer opened this issue Apr 8, 2021 · 4 comments · Fixed by #4100
Labels
Good First Issue A good issue to take on if you're just getting started with Iris development Type: Documentation

Comments

@rcomer
Copy link
Member

rcomer commented Apr 8, 2021

📚 Documentation

Example: in the contour description we have the keyword "coords: list of Coord objects or". Then "coordinate names" appears on the next line, outside the shading. This doesn't look right and I've spotted several other examples just in that module 🙁

Possibly this will come out in the wash of #3840?

Edit: #1942 changed many of the docstrings in iris.plot, so it's possible that the problem is largely limited to this module.

@trexfeathers
Copy link
Contributor

trexfeathers commented Apr 8, 2021

I certainly wouldn't have expected the docstring format for this to have successfully rendered in RTD.

With examples like this it's not often that we bother scouring the whole codebase and fixing everything at once, instead preferring to incrementally fix lines that we're touching while doing other work. Unfortunately that would make it very difficult to tell when this issue could be closed. Maybe an exhaustive check-and-fix of this problem is therefore necessary; it would probably make a good first issue?

@trexfeathers
Copy link
Contributor

Possibly this will come out in the wash of #3840?

I would definitely expect so, but that's an even bigger piece to finish.

@rcomer
Copy link
Member Author

rcomer commented Apr 8, 2021

Hmmm, now I've looked closer, this particular example was also wrong in the legacy docs so not a readthedocs issue. Looks like these docstrings were all re-jigged at #1942, so perhaps it is just this module? 🤔

@rcomer rcomer changed the title readthedocs argument rendering iris.plot arguments Apr 8, 2021
@rcomer
Copy link
Member Author

rcomer commented Apr 8, 2021

@trexfeathers thanks for your thoughts. I have reduced the scope of this issue to the iris.plot module, which should make it a lot easier to close 🙂

@trexfeathers trexfeathers added the Good First Issue A good issue to take on if you're just getting started with Iris development label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A good issue to take on if you're just getting started with Iris development Type: Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants