-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review documentation of cube.var_name #363
Comments
On the face of it ... 👍, but @esc24 - I have a vague feeling we discussed this already...? |
We did discuss it and I considered it together with 'CF-netCDF variable name' when I wrote the code and decided on just 'CF'. My reasons are:
To summarise, whilst CF does not standardize variable names, it's clear that it does constrain them (and Alistair's statement is therefore incorrect). Consequently, I opted for 'CF'. I'm 👎 on this. |
Well to come off the fence, I will support the original suggestion. |
@pp-mo - CF is central to our data model and as I pointed out, a CF variable name is not exactly the same thing as a netCDF variable name (due to the additional constraints - although I don't think I implemented them 😉 ). However, you make a good point that loading a netCDF file will populate the variable name so I'm ok with the proposed change, I'm just not in favour of it. |
Suggestion from Alistair Sellar...
In the docstring for cube.var_name, it should be described as a "netCDF variable name", not "CF variable name"
From: Sellar, Alistair
Sent: 19 February 2013 12:58
To: Peglar, Patrick
Subject: RE: WO0000000043571 - netcdf variable names in cubes // Cubes and netcdf
Perfect! You work so fast that you had answered my requirement before I even asked!
One small mistake in the documentation (I think):
http://scitools.org.uk/iris/docs/v1.2/iris/iris/cube.html#iris.cube.Cube.var_name
It says "The CF variable name for the Cube." and I think it should say "The NetCDF The CF variable name for the Cube.", as the variable name itself is not constrained by the CF conventions.
Thanks,
Alistair
Dr. Alistair Sellar Manager of Ocean Forecast Verification
Ocean Forecasting R&D
Met Office FitzRoy Road Exeter EX1 3PB United Kingdom
Tel: +44 (0)7909 099534
[email protected] http://www.metoffice.gov.uk
The text was updated successfully, but these errors were encountered: