Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci failures #236

Merged
merged 5 commits into from
Apr 27, 2022
Merged

fix ci failures #236

merged 5 commits into from
Apr 27, 2022

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description

This PR adds the setuptools-scm and setuptools-scm-git-archive as explicit package dependencies of cf-units, in order to resolve AttributeError: module 'cf_units' has no attribute '__version__' failures within CI e.g., see this recent GHA run.

Apart from added the appropriate package dependencies, we also required to:

  • bump the cache-build numbers
  • include an update of the lock-files for the new dependencies

Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjlittle! An important lesson learned

@trexfeathers trexfeathers merged commit da66cce into SciTools:main Apr 27, 2022
@bjlittle
Copy link
Member Author

Awesome, thanks @trexfeathers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New: Pull Request Highlight a new community raised pull-request Type: Bug Type: Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants