Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.toml #1102

Closed
wants to merge 27 commits into from
Closed

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Oct 26, 2024

@ErikQQY getting this error in Henon-Heiles_energy_conservation_benchmark.md . Doesn't look like it's related to the versions

image

@ErikQQY
Copy link
Member

ErikQQY commented Oct 26, 2024

I am sure this is caused by the version bumps, the "Quadruple Boson Energy Conservation" also failed because of this error, you may need to see what breaking changes led to this.

@ParamThakkar123
Copy link
Contributor Author

@ErikQQY the error occurred because in DiffEqCallbacks.jl the autodiff value is set to nothing. And these changes in DiffEqCallbacks are causing this issue.

image

@ErikQQY
Copy link
Member

ErikQQY commented Oct 27, 2024

The errors might caused by the outdated syntax, you can refer to the latest docs and see how to use the right syntax to fix the errors.

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Oct 27, 2024

@ChrisRackauckas the error shows that an autodiff or manifold_project should be used here. Which one should I use ?? The ForwardDiff from ForwardDiff module ??

@ParamThakkar123
Copy link
Contributor Author

@ErikQQY According to the docs manifold_jacobian is a parameter of the ManifoldProjection function. But while using it, it gives a method error saying there's nothing like that. Without using manifold_jacobian everything works fine locally but when I push the code the I get a method error in the CI

@ParamThakkar123
Copy link
Contributor Author

The latest syntax mentioned in the docs doesn't seem to work at all

@ErikQQY
Copy link
Member

ErikQQY commented Oct 29, 2024

The latest syntax mentioned in the docs doesn't seem to work at all

You might be doing something wrong with the syntax

Here are some useful tips you may find useful:

  1. Since this benchmark is not "that big" you can debug in your local environment and see what's going wrong, instead of waiting for CI to finish.
  2. Ensure your compats and Manifest are up-to-date.
  3. If you have trouble understanding how to correctly use the package, docs and test files are helpful.

@ChrisRackauckas
Copy link
Member

This is mixing Bayesian and dynamical. Please don't mix the bumps.

The PR name is not informative, is this supposed to be for Dynamical?

@ChrisRackauckas
Copy link
Member

Closing as it doesn't seem to have any real changes.

@ParamThakkar123 ParamThakkar123 deleted the DynamicalODE branch November 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants