Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter estimation #1099

Closed

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

I'm pretty sure this one needs updates to the callback syntax? Are you running these and making sure they are working? You keep telling me to review PRs that are not actually done and it's a big waste of time.

@ParamThakkar123
Copy link
Contributor Author

Yes @ChrisRackauckas , This still needs updates. Sorry if this annoys you but actually for some reason I am not able to run the Julia codes locally because somethings have messed up. I am trying to figure that out so I can run them locally. For now, whenever I am solving an issue I make a pull request and try to run it on the CI and see what comes

@ParamThakkar123
Copy link
Contributor Author

If the error says something I have already dealt with then I try to solve it by myself. If there's something I am finding hard to figure , I ask you to review because I know you can help me out. Nothing else

@ParamThakkar123
Copy link
Contributor Author

Sorry if this wasted your time and effort I can understand that. I will fix things so that everything runs well locally and I am able to run it locally so this doesn't happen again. Sorry again.

@ParamThakkar123
Copy link
Contributor Author

My system is now able to handle Julia well. I can perform all the tests now

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Nov 8, 2024

image

How to deal with this one ?? Is it actually a bug here ??

@ChrisRackauckas
Copy link
Member

I don't know, that would take some time to dive in, but I assume the majority of fixing this benchmark is likely figuring that one out.

@ChrisRackauckas
Copy link
Member

This is mixing dynamical and parameter estimation.

Closing because this doesn't have any real changes in it.

@ParamThakkar123 I'm going to recommend this project as a SciML Small Grant for someone else since there has been no progress made on it.

@ParamThakkar123 ParamThakkar123 deleted the ParameterEstimation branch November 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants