Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for unloaded extensions #236

Merged
merged 9 commits into from
Feb 18, 2024
Merged

Conversation

lxvm
Copy link
Collaborator

@lxvm lxvm commented Feb 16, 2024

Fixes #232

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@IlianPihlajamaa
Copy link
Contributor

Excellent, thanks!

@lxvm
Copy link
Collaborator Author

lxvm commented Feb 16, 2024

The way I've added the error at solve time here is somewhat different from https://github.com/SciML/NonlinearSolve.jl/blob/master/src%2Falgorithms%2Fextension_algs.jl. Would it be better to throw an error as soon as we construct the algorithm?

@ChrisRackauckas
Copy link
Member

I think it's better to error at the algorithm construction time. It both improves consistency and also gives information back to the user quicker.

@lxvm
Copy link
Collaborator Author

lxvm commented Feb 18, 2024

OK, I think this should be fixed to error in the constructor.

@ChrisRackauckas ChrisRackauckas merged commit 0286acb into SciML:master Feb 18, 2024
7 of 8 checks passed
@lxvm lxvm deleted the errors branch February 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful error message when not importing the correct packages
3 participants