Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive docs #848

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Revive docs #848

merged 7 commits into from
Jul 31, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Jul 29, 2023

I think this PR could revive the documentation

JuliaCon hackathon yeah!!🥳

Fixes #846

Signed-off-by: ErikQQY <[email protected]>
@ErikQQY ErikQQY changed the title Fix docs Revive docs Jul 30, 2023
@ErikQQY
Copy link
Member Author

ErikQQY commented Jul 30, 2023

It's so weird, the CI log doesn't show any useful information about the errors.

I checked the commit history and found that PR #819 broke the documentation, there was an error about the code in the new docs:

using Flux, Tracker

x = [0.8; 0.8]
ann = Chain(Dense(2, 10, tanh), Dense(10, 1))
p, re = Flux.destructure(ann)
z = re(Float64(p))

error:

ERROR: MethodError: no method matching Float64(::Vector{Float32})

Closest candidates are:
  (::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number}
   @ Base char.jl:50
  (::Type{T})(::Base.TwicePrecision) where T<:Number
   @ Base twiceprecision.jl:266
  (::Type{T})(::Flux.NilNumber.Nil) where T<:Number
   @ Flux D:\Julia\.julia\packages\Flux\n3cOc\src\outputsize.jl:18
  ...

@ChrisRackauckas
Copy link
Member

That code isn't ran though, so it can't be the issue?

@ErikQQY
Copy link
Member Author

ErikQQY commented Jul 30, 2023

Yeah, the CI still failed. Maybe we can try reverting PR #819?

@ChrisRackauckas
Copy link
Member

@avik-pal looks like a display error in Lux? https://github.com/SciML/DiffEqFlux.jl/actions/runs/5705070398/job/15459319933?pr=848 . I made it so it won't display. Let's see if that fixes the docs.

@ChrisRackauckas ChrisRackauckas merged commit 12f7392 into SciML:master Jul 31, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in Neural ODE example in docs
2 participants