feat: implement basic OnyxDatePicker component
#2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2e9e32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
larsrickert
force-pushed
the
feat/1818-datepicker
branch
from
277babb
to
0e4003a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsrickert
changed the title
OnyxDatePicker componentOnyxDatePicker component
larsrickert
changed the title
OnyxDatePicker componentOnyxDatePicker component
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
JoCa96
force-pushed
the
feat/1818-datepicker
branch
from
6b58b97
to
d2e9e32
Compare
JoCa96
reviewed
Nov 28, 2024
| <input | ||
| :id="inputId" | ||
| :key="props.type" | ||
| v-model="value" |
There was a problem hiding this comment.
Is there a particular reason why we don't use valueAsDate? Then we don't need to do the conversion magic ourselves 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1818
Implement a basic date picker comonent.
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)