Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Figma variable structure #372

Open
6 of 20 tasks
larsrickert opened this issue Feb 20, 2024 · 0 comments
Open
6 of 20 tasks

Implement new Figma variable structure #372

larsrickert opened this issue Feb 20, 2024 · 0 comments
Assignees
Labels
dev Requires technical expertise documentation Improvements or additions to documentation

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Feb 20, 2024

Why?

UX has changed the design variables logic to have a dedicated light and dark theme for every theme (e.g. onyx light and onyx dark) instead of the same light/dark variables which adapt based on the select theme (onyx, kaufland, lidl etc.).

Design

Figma file

Acceptance criteria

  • all components are updated to use the new variables
  • the Figma variables import workflow in GitHub is updated to work with the new variable structure
  • the variable docs are updated
  • all available quantitative color variables are shown on the color variables page with preview + copy functionality
  • the theming docs are updated accordingly
  • our Storybook theme is updated if needed
  • our VitePress theme is updated if needed
  • Storybook theme switch still works

Implementation details

Definition of Done

  • The following component requirements are implemented:
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • covered by tests
    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly
  • Namings are aligned with Figma

Approval

  • Storybook
  • Deployed Docs
  • approved by designer @jannick-ux
  • approved by dev
@larsrickert larsrickert added this to onyx Feb 20, 2024
@larsrickert larsrickert converted this from a draft issue Feb 20, 2024
@larsrickert larsrickert added ux Requires UX/UI design dev Requires technical expertise labels Feb 20, 2024
@larsrickert larsrickert added this to the Product improvements milestone Feb 20, 2024
@mj-hof mj-hof added the documentation Improvements or additions to documentation label May 15, 2024
@mj-hof mj-hof changed the title Docs: Show quantitatives colors in tokens Update documentation with new tokens and add quantative colors Sep 12, 2024
@mj-hof mj-hof moved this from New to Backlog in onyx Sep 12, 2024
@mj-hof mj-hof added the 0-refinement All issues that can or need to be estimated in our next refinement label Sep 12, 2024
@mj-hof mj-hof changed the title Update documentation with new tokens and add quantative colors Update everything with new variables Sep 12, 2024
@JoCa96 JoCa96 moved this from Backlog to New in onyx Sep 12, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Sep 12, 2024
@JoCa96 JoCa96 assigned larsrickert and unassigned JoCa96 Oct 2, 2024
@larsrickert larsrickert added the 0-refinement All issues that can or need to be estimated in our next refinement label Oct 9, 2024
@larsrickert larsrickert changed the title Update everything with new variables Implement new Figma variable structure Oct 9, 2024
@larsrickert larsrickert moved this from New to Backlog in onyx Oct 9, 2024
@larsrickert larsrickert removed the ux Requires UX/UI design label Oct 9, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Oct 9, 2024
@mj-hof mj-hof moved this from Backlog to Ready in onyx Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise documentation Improvements or additions to documentation
Projects
Status: In Progress
Development

No branches or pull requests

4 participants