Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long click on a message is triggered too fast #237

Open
chagai95 opened this issue Apr 24, 2024 · 2 comments
Open

Long click on a message is triggered too fast #237

chagai95 opened this issue Apr 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@chagai95
Copy link

chagai95 commented Apr 24, 2024

Describe the bug
Sometimes when scrolling up the menu of a message is triggered because the long press is detected. Sometimes even twice because it's so easy to trigger.

To Reproduce
https://youtu.be/y7KJKJCIBEo?si=wymTFVpz5hMFhGKL

Expected behavior
set the time to a few more milliseconds before triggering the opening of the menu

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Xiaomi 11t pro
  • OS: MIUI

Additional context

  • App version: 1.6.12.sc77 [40101270] (G-2c9104ca)
  • Store: Google Play
  • Homeserver: [e.g. matrix.org]
  • Related labs settings: don't think so
  • Logs have been submitted using the app's built-in bug report (/"rageshake") mechanism: no

Upstream relevance

  • Does this issue exist in Element Android? Haven't checked the latest version but it doesn't in an older version.
  • If this issue exists in Element Android, please also link the corresponding bug report (create a new one if it doesn't exist yet)

Add any other context about the problem here.

@SpiritCroc SpiritCroc added the upstream This issue is also applicable upstream label Apr 27, 2024
@chagai95
Copy link
Author

@SpiritCroc this is not happening on element, is this perhaps related to an older version of upstream? Or is the newest release merged? Can I somehow help take a look at this? Could you point me to the approximate location in the code? I've been fighting with this for weeks now and it's extremely annoying...

@SpiritCroc
Copy link
Member

We're up-to-date on upstream merges. Not sure where to look for this, looks like some longpress listener getting touch events when it shouldn't since the list is scrolling, but no idea which of Schildi's changes would affects that. Being able to reproduce on a version where you can add debugging statements yourself while seeing what happens sounds like a good starting point, if that is in your skillset.

@SpiritCroc SpiritCroc added bug Something isn't working and removed upstream This issue is also applicable upstream labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants