Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-runners and github-workflow.json #3208

Open
drorata opened this issue Sep 8, 2023 · 5 comments
Open

azure-runners and github-workflow.json #3208

drorata opened this issue Sep 8, 2023 · 5 comments
Labels
help wanted issue:bug Report errors or unexpected behavior (auto-generated by issue forms)

Comments

@drorata
Copy link

drorata commented Sep 8, 2023

Area with issue?

JSON Schema

✔️ Expected Behavior

A snippet like:

jobs:
  ci:
    runs-on: azure-runners

Should be acceptable when writing a GitHub workflow.

❌ Actual Behavior

image

YAML or JSON file that does not work.

https://json.schemastore.org/github-workflow.json

IDE or code editor.

Visual Studio Code

Are you making a PR for this?

Yes, I will create a PR.

@drorata drorata added the issue:bug Report errors or unexpected behavior (auto-generated by issue forms) label Sep 8, 2023
@JohnLBergqvist
Copy link

JohnLBergqvist commented Oct 2, 2023

With GitHub's support for the new Actions Runner Scale Sets, you can just use runs-on: my-scale-set-name to specify which scaleset you want the runner to use. https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/using-actions-runner-controller-runners-in-a-workflow#about-using-arc-runners-in-a-workflow-file

To use this configuration in a workflow, set the value of the runs-on key in your workflow to arc-runner-set, similar to the following example.

jobs:
  job_name:
    runs-on: arc-runner-set

@MPV
Copy link

MPV commented Oct 2, 2023

@drorata
Copy link
Author

drorata commented Oct 2, 2023

  • @JohnLBergqvist I don't understand your comment; "Yes" = ?
  • @MPV I agree that it seem to be related...

Are you saying that the name azure-runners is a custom one? Does it mean that each organization can define custom names that will be hard to track on in the SchemaStore?

@MPV
Copy link

MPV commented Oct 2, 2023

Are you saying that the name azure-runners is a custom one? Does it mean that each organization can define custom names that will be hard to track on in the SchemaStore?

Yes it's now possible (and recommended for GHA ARC, as per the link) to have custom runs-on for your RunnerScaleSets.

@drorata
Copy link
Author

drorata commented Oct 2, 2023

So there's no way of validating the "allowed" values globally, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issue:bug Report errors or unexpected behavior (auto-generated by issue forms)
Projects
None yet
Development

No branches or pull requests

4 participants