Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method the same after erasure #400

Closed
dispalt opened this issue Jan 13, 2022 · 3 comments
Closed

Method the same after erasure #400

dispalt opened this issue Jan 13, 2022 · 3 comments

Comments

@dispalt
Copy link

dispalt commented Jan 13, 2022

Upgraded from 1.0.0-beta35 -> 1.0.0-beta37 and now I am getting these:

Looking through the release notes I'm guessing it's related to the js.Any -> Any transition.

[error] have same type after erasure: (props: Object): Unit, [Error] /home/dan/projects/core/client-comp/target/streams/_global/stImport/_global/streams/sources/a/antv__g2plot/src/main/scala/typings/antvG2plot/mod
/PercentStackedColumn.scala:10: name clash between inherited members:
[error] def createLayers(props: typings.antvG2plot.percentStackedColumnMod.PercentStackedColumnConfig with typings.antvG2plot.anon.Layers): Unit in trait BasePlot and
[error] def createLayers(props: Any): Unit in trait PercentStackedColumn
@oyvindberg
Copy link
Collaborator

Yeah, it's either that change, or #355 , if you're on scala 2.

I'll need some info for this. if you're using sbt and the plugin, run this:

sbt> debug
sbt> stImport
[debug] ScalablyTypedConverterPlugin.scala:44 input.asJson.spaces2 {
[debug]   "converterVersion" : "1.0.0-beta37",
[debug]   "conversion" : {
[debug]     "useScalaJsDomTypes" : true,
[debug]     "flavour" : "normal",
[debug]     "outputPackage" : "typings",
[debug]     "enableScalaJsDefined" : {
[debug]       "AllExcept" : {
[debug]         "values" : [
[debug]         ]
[debug]       }
[debug]     },
[debug]     "stdLibs" : [
[debug]       "dom",
[debug]       "es6"
[debug]     ],
[debug]     "expandTypeMappings" : {
[debug]       "AllExcept" : {
[debug]         "values" : [
[debug]           "prop-types",
[debug]           "react",
[debug]           "std"
[debug]         ]
[debug]       }
[debug]     },
[debug]     "ignored" : [
[debug]       "typescript"
[debug]     ],
[debug]     "versions" : {
[debug]       "scala" : "3.1.0",
[debug]       "scalaJs" : "1.8.0"
[debug]     },
[debug]     "organization" : "org.scalablytyped",
[debug]     "enableReactTreeShaking" : {
[debug]       "NoneExcept" : {
[debug]         "values" : [
[debug]         ]
[debug]       }
[debug]     },
[debug]     "enableLongApplyMethod" : false,
[debug]     "privateWithin" : null
[debug]   },
[debug]   "wantedLibs" : {
[debug]     "vue" : "2.6.11"
[debug]   }
[debug] } [project => vue, ms => 0]

Also just FYI, i downloaded the newest version of the library and it converted successfully with scala 3. for scala 2 it was caught up in an error caused by a pretty crazy inheritance hierarchy.

@dispalt
Copy link
Author

dispalt commented Jan 13, 2022

Yeah I am definitely still on scala 2 and will be a for a bit. Ill get you that info shortly.

@dispalt
Copy link
Author

dispalt commented Jan 18, 2022

I gave up on this library, so I guess it doesn't matter, I never used it directly.

@dispalt dispalt closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants