Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalablyTypedConverterPlugin 1.0.0-beta36 generates invalid code from @tokenizer/token #376

Closed
seraphr opened this issue Oct 21, 2021 · 1 comment

Comments

@seraphr
Copy link

seraphr commented Oct 21, 2021

Source

https://github.com/Borewit/tokenizer-token/blob/432ffe2187a29020c23cb52501f81009dddb7821/index.d.ts#L12-L18

  /**
   * Decode value from buffer at offset
   * @param array - Uint8Array to read the decoded value from
   * @param offset - Decode offset
   * @return decoded value
   */
  get(array: Array, offset: number): Value;

Generated

  /**
    * Decode value from buffer at offset
    * @param array - Uint8Array to read the decoded value from
    * @param offset - Decode offset
    * @return decoded value
    */
  def get(array: js.Array, offset: Double): Value = js.native

Error

class Array takes type parameters 
@oyvindberg
Copy link
Collaborator

Thanks for the report!

Hah, this was a entertaining one, who thought Array would show up as a type parameter name :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants