Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Bump versions #383

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[CHORE] Bump versions #383

merged 4 commits into from
Dec 13, 2024

Conversation

Jake1698
Copy link
Contributor

@Jake1698 Jake1698 commented Dec 13, 2024 •
edited
Loading

Task name here

Fixes #375

Types of change

  • Enhancement

Comments (optional)

  • Update to use new version of core dependencies
  • Script and manual testing working well

@Jake1698 Jake1698 marked this pull request as ready for review December 13, 2024 05:37
@Jake1698
Copy link
Contributor Author

Fixed with latest commit @Nadai2010

@Jake1698 Jake1698 requested a review from Nadai2010 December 13, 2024 09:10
Nadai2010
Nadai2010 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is update ok, the contract deploy Sepolia well and is verified well by Walnut

imagen

imagen

imagen

metalboyrick
metalboyrick approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my end, thanks for the work!

@metalboyrick metalboyrick merged commit bbc5525 into Scaffold-Stark:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadai2010 Nadai2010 Nadai2010 approved these changes

@metalboyrick metalboyrick metalboyrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] Update tool versions , Scarb and starknet-foundry, cairo, devnet-rs
3 participants
@Jake1698 @metalboyrick @Nadai2010