Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add isFork to the scaffold.config.ts #378

Open
metalboyrick opened this issue Dec 11, 2024 · 21 comments
Open

[CHORE] Add isFork to the scaffold.config.ts #378

metalboyrick opened this issue Dec 11, 2024 · 21 comments

Comments

@metalboyrick
Copy link
Collaborator

metalboyrick commented Dec 11, 2024

Issue Overview

Add tag for fork (you can call it isFork) on scaffold.config.ts and don't show wrong network dropdown if fork is true. refer to this PR for more context: https://github.com/Scaffold-Stark/scaffold-stark-2/pull/320/files

Proposed Solutions or Ideas

  • Add the property in scaffold.config.ts
  • Something to note: the chain ID of a fork is the same as the target network. i.e. if you are on a fork of mainnet, your chain id is MAINNET_CHAINID and your RPC url is localhost. This can cause some issues which lead to wrong network currently, because the framework expects localhost rpc to be = devnet.
  • make sure services that depend on network are working properly : conditionals like starknet id, faucet, a fork is same as devnet but with a different chain id
@metalboyrick metalboyrick changed the title [TEST] Add isFork to the scaffold.config.ts [CHORE] Add isFork to the scaffold.config.ts Dec 11, 2024
@jaykayudo
Copy link

can i be assigned this issue?
I am a full stack developer with ample experience in building innovative and scalable solutions.

How i will tackle this

  • I will follow the contribution guideline to the letter
  • I will add the property isFork to scaffold.config.ts and follow the details in the description
  • I will open a PR within 2 business days

@MooreTheAnalyst
Copy link

Can I jump on this task?
In scaffold.config.ts, i will add a new boolean property isFork and set it to true when running on a forked network, then update the logic for displaying the wrong network dropdown to check this property, and skip rendering the dropdown if isFork is true.

@Supa-mega
Copy link

Can I take this issue?

@petersdt
Copy link

I’m interested in this one.

@jedstroke
Copy link

Let me try this one!

@raizo07
Copy link
Contributor

raizo07 commented Dec 12, 2024

I'd like to take this issue. I'm a Software developer with over 3 years experience

@od-hunter
Copy link

Hi, please can I be assigned this please? I would love to be the given the opportunity to solve this issue please. I have experience in html, css, JavaScript,TypeScript and solidity, and Cairo
I have gone through the pr and I’ll say I’m up for the task and I’ll ask more questions if I have any.

Kindly assign me please.

@NowGoody
Copy link

Can I take care of this issue?

@abdegenius
Copy link
Contributor

I’d love to work on this task.

@1nonlypiece
Copy link

Hi,
I’d like to work on this issue as I have experience with Cairo and building on StarkNet, including writing and optimizing smart contracts.

ETA:
I estimate completing this task in about 12-24 hours. Let me know if I can get started!

@aniruddhaaps
Copy link

To solve this problem:

I would add an isFork property in scaffold.config.ts. Set it appropriately based on requirement.
Then update the logic driving the network dropdown so that it does not show when isFork is true.
See the linked PR for implementation context and align changes with existing codebase.

@Jagadeeshftw
Copy link

Hi,
I’d love to work on this issue as I have strong experience in developing secure and efficient smart contracts using Cairo and deploying them on StarkNet. Please assign this to me, and I’ll ensure to deliver a robust and high-quality PR within 12-24 hours.

@ncoquelet
Copy link

Hey,

I'm a dev with 20 years of XP, super comfy with TypeScript, React/Next, Dapps, Prisma, CI/CD. I ship fast and high-quality stuff. Worked with AFK and GoStarkMe, check my GitHub profile for more details (got several hackathon prizes).
Currently doing Basecamp 11.

Down to handle this task.

@Pvsaint
Copy link

Pvsaint commented Dec 12, 2024

I’d love to work on this task please, I'm Victor Peter, a front-end and smart contract developer. I promise to write a pixel perfect code.

@ONEONUORA
Copy link

May I take this issue on? I am a full stack and blockchain developer. ETA 24 hours

@kayceeDev
Copy link

I'd love to work on this!

@ShantelPeters
Copy link

Could I try solving this?

@Amarjeet325
Copy link

Can I take care of this issue?

@vestor-dev
Copy link

Can I try solving this issue?

@TheSQLguy
Copy link

To solve this problem:

I would add an isFork property in scaffold.config.ts. Set it appropriately based on requirement.
Then update the logic driving the network dropdown so that it does not show when isFork is true.
See the linked PR for implementation context and align changes with existing codebase.

@BrunoAmbricca
Copy link

I would like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests