Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Create unit tests for utils/scaffold-stark/types.ts file #371

Open
metalboyrick opened this issue Dec 11, 2024 · 15 comments
Open

[TEST] Create unit tests for utils/scaffold-stark/types.ts file #371

metalboyrick opened this issue Dec 11, 2024 · 15 comments

Comments

@metalboyrick
Copy link
Collaborator

Issue Overview

Unit tests required for the indicated file to ease future refactoring and feature validations.

Proposed Solutions or Ideas (more like tips and reminders)

  • We use vitest to run the unit tests, can refer to their documentation for the syntax: https://vitest.dev/, Jest developers shouldn't have too much of a hard time getting used to the syntax.
  • Note that hooks testing tools are also now imported via @testing-library/react,
  • Please refer to README.md on how to execute the tests
  • Use it.only() to isolate tests in case you need to, but do not forget to remove it once you are submitting your PR.
  • Mock when necessary. please make sure that the tests NOT ONLY works on your device
  • If you're not sure of the features of the code unit to test, please refer to the documentation, or free to ask on this issue page or on the Telegram Group

Code Coverage

IMPORTANT - When submitting a PR, please provide a screenshot of the coverage for the specific units you are working on. We would like to achieve >= 70 % code coverage.

Happy Hacking!

Example:
image

@Ayoazeez26
Copy link
Contributor

I will write vitest tests for the file and ensure test passes completely before making PR.
ETA - 1 day.

@petersdt
Copy link

I'd love to work on this!

@Supa-mega
Copy link

May I take care of this?

@No-bodyq
Copy link

I’d like to resolve this.

@vestor-dev
Copy link

Mind if I try this one?

@1nonlypiece
Copy link

Hi,
I’d like to work on this issue as I have experience with Cairo and building on StarkNet, including writing and optimizing smart contracts.

ETA:
I estimate completing this task in about 12-24 hours. Let me know if I can get started!

@abdegenius
Copy link
Contributor

I’m interested in this one.

@coxmars
Copy link

coxmars commented Dec 12, 2024

I'm a software developer with 2+ years of experience and I have worked with backend technologies such as Cairo, Java, C# and frontend with React, NextJS, JS/TS. Also, I'm a member of the Dojo Coding community here in CR and I have made contributions in Cairo VM Go, Cairo VM TS, Cairo Lints etc. Likewise, I’m a Cairo developer working in ByteBuildersLabs creating on-chain games using the Dojo framework.

This is my approach:

1- I will review the project structure to place the tests as expected.
2- I’m going to use the code structure/best practices implemented among the project codebase to continue the standard
3- I'm going to add the unit tests passing with >= 70 % code coverage.

Here I applied unit tests with Vitest: ArkProjectNFTs/ark-market#181

ET: 3 days

@Jagadeeshftw
Copy link

Hi,
I’d love to work on this issue as I have strong experience in developing secure and efficient smart contracts using Cairo and deploying them on StarkNet. Please assign this to me, and I’ll ensure to deliver a robust and high-quality PR within 12-24 hours.

@martinvibes
Copy link
Contributor

i'm a frontend dev and blockchain dev
i would love to work on this and get it done
I’m interested in this one.
kindly assign

@coxmars
Copy link

coxmars commented Dec 12, 2024

I'm a software developer with 2+ years of experience and I have worked with backend technologies such as Cairo, Java, C# and frontend with React, NextJS, JS/TS. Also, I'm a member of the Dojo Coding community here in CR and I have made contributions in Cairo VM Go, Cairo VM TS, Cairo Lints etc. Likewise, I’m a Cairo developer working in ByteBuildersLabs creating on-chain games using the Dojo framework.

This is my approach:

1- I will review the project structure to place the tests and other parts as expected.
2- I’m going to use the code structure/best practices implemented among the project codebase to continue the standard
3- I'm going to add the unit tests passing >= 70 % code coverage.

I implemented the same here: ArkProjectNFTs/ark-market#181

ET: 3 days

@ShantelPeters
Copy link

I’d like to work on this.

@ryzen-xp
Copy link

Is this issue still available?

@NueloSE
Copy link
Contributor

NueloSE commented Dec 12, 2024

am a software developer with experience in create web applications and writing test to ensure proper functionality of these applications.
I have handled similar issue in past odhack

check the link to similar task

@BrunoAmbricca
Copy link

I would like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests