Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add starknet pfp resolution #386

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add starknet pfp resolution #386

wants to merge 2 commits into from
+29 −19

Conversation

JoE11-y
Copy link

@JoE11-y JoE11-y commented Dec 13, 2024 •
edited
Loading

[FEAT] StarknetID PFP Resolution

Fixes #370

Types of change

  • Feature
  • Bug
  • Enhancement

Comments (optional)

@JoE11-y
Copy link
Author

JoE11-y commented Dec 13, 2024

@metalboyrick this is ready for review.

Nadai2010
Nadai2010 reviewed Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine on devnet, sepolia and mainnet.

Could you please check the error in console logs and try to resolve the error "[useScaffoldStarkProfile] No data found for the given address"?

Captura desde 2024-12-14 06-59-18

@metalboyrick
Copy link
Collaborator

It works fine on devnet, sepolia and mainnet.

Could you please check the error in console logs and try to resolve the error "[useScaffoldStarkProfile] No data found for the given address"?

Captura desde 2024-12-14 06-59-18

That log is expected if the address can't be queried with starknet id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadai2010 Nadai2010 Nadai2010 left review comments

@metalboyrick metalboyrick Awaiting requested review from metalboyrick

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] StarknetID PFP Resolution
3 participants
@JoE11-y @metalboyrick @Nadai2010