Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array size question #4

Closed
forty opened this issue Mar 4, 2024 · 2 comments
Closed

Array size question #4

forty opened this issue Mar 4, 2024 · 2 comments

Comments

@forty
Copy link

forty commented Mar 4, 2024

Hello,

I'm just reading code out of curiosity. Shouldn't this be 64 bytes? https://github.com/Sc00bz/bscrypt/blob/main/blake2b.cpp#L73

@Sc00bz
Copy link
Owner

Sc00bz commented Mar 8, 2024

Yes and fixed. Funny thing I've been meaning to replace the BLAKE2b code with a standard library (like https://github.com/BLAKE2/libb2), but then it's no longer cross platform and no longer self contained.

@Sc00bz Sc00bz closed this as completed Mar 8, 2024
@forty
Copy link
Author

forty commented Mar 8, 2024

For what it's worth, I feel self contained and portable is good for the reference implementation. It would also be nice to have docs & test vectors, but I guess it's already tracked here #2 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants