Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image viewer (converter) does not allow for, or indicate, the choice of Q units. #1811

Open
butlerpd opened this issue Apr 1, 2021 · 2 comments
Labels
Enhancement Feature requests and/or general improvements Good First Issue Issues that are appropriate for newbies Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Apr 1, 2021

When loading an image file and clicking convert, the user must enter the Qmax and Qmin in (I believe) units of A^-1. It would be nice to offer the option of units much as is being done for the load data currently in progress under review #1802 and discussed in issue #1465. However to a minimum the labeling of the text entry box should be changed from the current x values from pixel # to: X_min (or X_max, Y_min,Y_max) to something like: x values from pixel # to:Q_min (1/A) etc.

I assume the z value is expected to be in arbitrary units but a statement of such would be useful.

If the minimum of fixing labels is done a new ticket should be generated before closing this one for the option of choosing the units (assuming the data object will carry native units) though downgrading to minor might be appropriate?

@butlerpd butlerpd added Major Big change in the code or important change in behaviour SasView GUI Enhancements labels Apr 1, 2021
@butlerpd butlerpd added this to the SasView 5.1.0 milestone Apr 1, 2021
@butlerpd butlerpd added the Good First Issue Issues that are appropriate for newbies label Apr 1, 2021
@lucas-wilkins
Copy link
Contributor

@krzywon What is the state of this with regards to the new units?

@krzywon
Copy link
Contributor

krzywon commented Oct 31, 2022

@lucas-wilkins Still needs to remain open and I didn't realize this was required until now.

@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements and removed SasView GUI Enhancements labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Good First Issue Issues that are appropriate for newbies Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants