Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure 1D data masks apply to fits (Trac #1055) #1113

Open
pkienzle opened this issue Mar 30, 2019 · 3 comments
Open

make sure 1D data masks apply to fits (Trac #1055) #1113

pkienzle opened this issue Mar 30, 2019 · 3 comments
Labels
Cross Package Issue This issue involves a package other than SasView/sasview Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

Following up from ticket #1104, [https://github.com//pull/135 PR http://trac.sasview.org/ticket/135], make sure that masking applies to resolution and fits in 1D datasets.

Migrated from http://trac.sasview.org/ticket/1055

{
    "status": "new",
    "changetime": "2018-02-13T02:48:24",
    "_ts": "2018-02-13 02:48:24.630207+00:00",
    "description": "Following up from ticket #1037, [https://github.com/SasView/sasview/pull/135 PR #135], make sure that masking applies to resolution and fits in 1D datasets.\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2018-01-03T17:42:06",
    "component": "SasView",
    "summary": "make sure 1D data masks apply to fits",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
@pkienzle pkienzle added this to the SasView 4.3.0 milestone Mar 30, 2019
@pkienzle pkienzle added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2018/02/13 02:48:24: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

@butlerpd butlerpd modified the milestones: SasView 4.3.0, SasView 5.1.0 Apr 26, 2020
@butlerpd
Copy link
Member

This indeed needs to be looked into. I am guessing that 1D masks are part of the SasView 1Ddata object structure? though not even sure of that since most early 1D formats do not include masks for 1D data. But masking in general was not something that was thought of much in the original SasView implementation. It was added for 2D fitting but there is nothing added for 1D (and arguably even less necessary for 1D reduced data than 2D?). The NXcanSAS format does allow for masks so should be able to respect that. Guessing however we can move this to 5.1

@krzywon
Copy link
Contributor

krzywon commented Apr 27, 2020

The 1D data structure has no concept of masks. The mask object for the 2D data was built into the parent plottable_2D class but was never implemented in plottable_1D. Once the mask is added to the plottable class, passing it to the GUI and perspectives might need to be added.

@krzywon krzywon added Cross Package Issue This issue involves a package other than SasView/sasview and removed SasData - Add Ticket labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Package Issue This issue involves a package other than SasView/sasview Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

5 participants