Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize 1D and 2D data #17

Open
7 tasks
krzywon opened this issue Sep 16, 2022 · 1 comment
Open
7 tasks

Generalize 1D and 2D data #17

krzywon opened this issue Sep 16, 2022 · 1 comment

Comments

@krzywon
Copy link
Collaborator

krzywon commented Sep 16, 2022

As noted in SasView/sasview#841, the 1D and 2D data objects could be abstracted out into a single class. This would allow more generic data formats to be added as needed.

In this package, the following is required:

  • Combine the plottable_1d and plottable_2d classes into a single class (called plottable?)
  • Combine the Data1D and Data2D classes into a single class (called Data?)
  • Update all base file loader class
  • Update all specific reader classes
  • Update file conversion routines
  • Update manipulations (currently only works for 2D data and there are checks for this)
  • Update unit tests to match new functionality
@lucas-wilkins
Copy link
Contributor

Solutions to this might be relevant to SasView/sasview#506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants