Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow passing the requested parameters as program arguments #13

Closed
ChiefArug opened this issue Sep 30, 2022 · 7 comments · Fixed by #36
Closed

[FEATURE] Allow passing the requested parameters as program arguments #13

ChiefArug opened this issue Sep 30, 2022 · 7 comments · Fixed by #36
Assignees
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community feature ✨ New feature request or addition good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest
Milestone

Comments

@ChiefArug
Copy link

Is your feature request related to a problem? Please describe.
Currently you have to manually put in each argument as the program asks for them, this would allow inputting some or all of them as program arguments.

Describe the solution you'd like
Allow passing the various inputs it asks for as program arguments. They should be input in the same order as asked for, so link fName downloadsFolder. The program should still ask for any values not provided, or if a blank value was provided.
if downloadsFolder is y then it should try to find the default downloads folder. If it cannot find that or n was passed in then it should ask for one. If it is any other value it should be interpreted as a path. This may cause a conflict with saving to drives named y or n, I am not sure how that works exactly. If that is a problem then this could be split into two arguments, one for if a custom path should be used and a second for the custom path.

It could be worthwhile reording the arguments so that link and fName come last, which would make it easier to have a sort of 'default' downloader setup that has the downloads folder selected.

Example program arguments: https://example.com/my_file.txt "My file.txt" y which would download the file from the mentioned link and save it as My file.txt in the default downloads folder if found, asking the user for input if it cannot be found.

@ChiefArug ChiefArug added the feature ✨ New feature request or addition label Sep 30, 2022
@SaptarshiSarkar12
Copy link
Owner

@ChiefArug Thanks for this issue.
If anyone wants to work on this issue, please comment below. I shall assign you with the task.

@SaptarshiSarkar12 SaptarshiSarkar12 added good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community labels Sep 30, 2022
@Rishav-12
Copy link

hey @SaptarshiSarkar12 can I take this up? Let me know

@SaptarshiSarkar12
Copy link
Owner

Yes @Rishav-12 . Please make sure that you will link this issue to your PR.

@Rishav-12
Copy link

Hey, I'm sorry but I think I won't be able to do this since my code breaks for some reason and I'm not willing to dive too much into these errors. So I'll unassign myself, if anyone else wants to take this up feel free

@Rishav-12 Rishav-12 removed their assignment Oct 1, 2022
@SaptarshiSarkar12
Copy link
Owner

Ok @Rishav-12 .
If anyone wants to work on this issue, please comment below and I shall assign you with the task.

@SaptarshiSarkar12 SaptarshiSarkar12 added the help wanted Extra attention and support, and contributors are needed label Oct 2, 2022
@Anurag-Bharati
Copy link
Contributor

I can work on this.

@SaptarshiSarkar12
Copy link
Owner

I can work on this.

Okay, assigning you with the task. Please link this issue to your PR

@SaptarshiSarkar12 SaptarshiSarkar12 removed the help wanted Extra attention and support, and contributors are needed label Oct 2, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 moved this to Done in Drifty Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title [FEATURE] Allow inputting the requested parameters as program arguments [FEATURE] Allow passing the requested parameters as program arguments Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added the App 💻 Issues/Pull Requests which update Drifty Application Code label Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v1.2.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community feature ✨ New feature request or addition good first issue Good for newcomers hacktoberfest Issues/Pull Requests for Hacktoberfest
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants