Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eventManger module #22

Open
DecDuck opened this issue Aug 14, 2023 · 1 comment
Open

Remove eventManger module #22

DecDuck opened this issue Aug 14, 2023 · 1 comment

Comments

@DecDuck
Copy link
Member

DecDuck commented Aug 14, 2023

There's no documentation and it seems pretty unused.

To remove we'd have to delete the module but then remove the hooks in scripts/mainThread/controller.lua

This technically would be a breaking change so we should consider deprecating first (but I don't think we have a large enough of a developer-base to justify it)

@SirLich
Copy link
Collaborator

SirLich commented Aug 15, 2023

Event manager is indeed quite old, and not that useful. I think the kernel of the idea is useful, but current implementation is not. I do believe I use it in one of my mods, but it should be easy to replace.

I do think it would be nice to resurrect as some kind of generic cross-thread RPC though, since I don't like shadowing server.lua to register the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants