Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] source sound effects from myinstants #9

Open
suyashb95 opened this issue Sep 17, 2020 · 1 comment
Open

[feature request] source sound effects from myinstants #9

suyashb95 opened this issue Sep 17, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@suyashb95
Copy link

This is a pretty cool project!
It'd be great if success/error sounds can be played directly from myinstants. It has a massive repository of different sound effects and most of them are small enough( < 250KB ) to be downloaded(maybe asynchronously?) and played on the fly. This way the tracks needn't be bundled with the repo and there won't be licensing issues

e.g. https://www.myinstants.com/media/sounds/curb-your-enthusiasm.mp3

The user would probably provide the URL in the decorator like so

@on_error(<myinstants_url>) or @on_success(<myinstants_url>)
@Sangarshanan
Copy link
Owner

Woah!!! this is lovely, it would indeed be a cool addition, Thank you so much for bringing this up

Will take some time to go through the https://www.myinstants.com/terms_of_use.html and think about the integration

@Sangarshanan Sangarshanan added the enhancement New feature or request label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants