-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the database from schema_holder table, mysql and postgres in case onboarding fails #47
Comments
@suyashgautam I can work on this, feel free to assign the issue to me. |
Sure @Deekshithrathod , I have assigned this issue to you. |
Hi @Deekshithrathod any progress on this issue? We can discuss if you are facing any issues |
Started working today, I'll reach out if I face any roadblocks. Updated: |
Hey @suyashgautam, I understand that you might be swamped with work. If you don't mind can you take a look at the message I left a message on discord yesterday? This is the message |
Hi @Deekshithrathod Hope you are doing well. I wanted to check any updates on this ticket? |
@suyashgautam Yes, I finally got help on Discord & set up the project on GitPod yesterday. Narrowed down the scope, i.e. figured out that the changes that need to be made might go here. Since I'm new to Python, I'm trying to wrap my head around Quart (at least the basics) & make changes. Is this blocking any other issues? I was planning to get to this today or tomorrow. |
@Deekshithrathod That is good to hear you are able to proceed forward. |
@suyashgautam You should un-assign me & give it to someone else. I didn't get time to get to it over the weekend & it seems like I'll be busy this week as well. |
Currently, if onboarding fails then in that case a record still persists in the schema_holder table. Also in case the file fails in between then the schema still persists in that particular database type.
For example - I am onboarding a mysql database and schemaid is "abc" and the file failed while creating a table in that case a record will still be present in schema_holder table and also the mysql db where we are replicating the db.
Make code changes such that we could fix this issue.
The text was updated successfully, but these errors were encountered: