[W-8857319] SFDX conversion and dataset updates #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spelak-salesforce
added
the
🎯 this sprint
|
@davidmreed , FYI: Orion will is planning on merging this PR this sprint. We are in progress creating a child branch to fix the |
spelak-salesforce
changed the title
…dit to pass (#83) * Updating Hardcoded string to Constants on Disbursement Helper JS File. * Removing cons logs and missing hardcoded strings * Removing setDefaultModel call Disbursement Controller file. setDefaultModel is now being called from the init method in helper file. * Removing extra spaces under attributes definition * Remove defaultModel attribute usage. - The DEFAULT_MODEL values are set directly on setDefaultModel method so there is not need to use an aura attribute to perform this operation.
|
@davidmreed , can you give this a look over before we start reviewing. Also, can we get a code owner review by @SalesforceFoundation/release-engineering-reviewers ? Devs will start reviewing. |
|
@spelak-salesforce I created this PR but I think it's ready to go. @jstvz will have to approve it for CODEOWNERS since I cannot. |
jstvz
approved these changes
Feb 10, 2021
scottwarren-sfdo
approved these changes
Feb 10, 2021
scottwarren-sfdo
added
ready for QE
gaganpsandhu
added
QE in Progress
scottwarren-sfdo
added
the
Parent Branch
gaganpsandhu
removed
the
QE in Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures maintenance work done for a demo, including converting Outbound Funds to SFDX format and updating the dataset and mapping file.
Critical Changes
Changes
Issues Closed