Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify impute #36

Merged
merged 4 commits into from
Nov 30, 2023
Merged

simplify impute #36

merged 4 commits into from
Nov 30, 2023

Conversation

tylerjthomas9
Copy link
Contributor

Ref #34

@tylerjthomas9 tylerjthomas9 changed the title simplify impute simplify impute, switch to YASStyle Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3aef664) 79.46% compared to head (a2d47bd) 87.11%.

❗ Current head a2d47bd differs from pull request most recent head e17aade. Consider uploading reports for the commit e17aade to get more accurate results

Files Patch % Lines
src/data/daily_bar_csv.jl 84.21% 3 Missing ⚠️
src/portfolio/portfolio.jl 40.00% 3 Missing ⚠️
ext/MarketDataExt.jl 0.00% 2 Missing ⚠️
src/backtest_trading_session/qts.jl 0.00% 2 Missing ⚠️
src/broker/simulated_broker.jl 88.88% 1 Missing ⚠️
src/rebalance/daily.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   79.46%   87.11%   +7.64%     
==========================================
  Files          39       39              
  Lines         979      908      -71     
==========================================
+ Hits          778      791      +13     
+ Misses        201      117      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjthomas9 tylerjthomas9 changed the title simplify impute, switch to YASStyle simplify impute Nov 30, 2023
@tylerjthomas9 tylerjthomas9 merged commit 575c410 into main Nov 30, 2023
6 checks passed
@tylerjthomas9 tylerjthomas9 deleted the tyler-rework-impute branch November 30, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant