fix(auto-insert): restore content of context instead of undo #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzbdmw
force-pushed
the
auto-insert
branch
2 times, most recently
from
091b3ce to
f9d4b20
Compare
|
Blink has the same issue with nvim-cmp when used with mini.snippets, but should not related to this pr, I'd open a new one. |
|
I feel this function is unnecessary (keep it a blank body also fix these two issues), we already handles text_edits smartly, it says This pr sort of emulate the restore functionality by deleting chars until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #942
fix #810
Described in #942 (comment), this pr removes the
preview_undofield and make the auto_insert stateless.