Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant tapping features functionality #61

Closed
th1vairam opened this issue Oct 29, 2018 · 2 comments
Closed

Redundant tapping features functionality #61

th1vairam opened this issue Oct 29, 2018 · 2 comments
Assignees

Comments

@th1vairam
Copy link
Collaborator

Why there are two functions with very similar use cases? get_tapping_features and tapping_features? Do we really need them both?

@itismeghasyam
Copy link
Contributor

I just named them that ways, so that if need arises, we can incorporate models into tapping like we did for accelerometer and gyroscope. If not, then we can possibly get rid of one of those

@th1vairam
Copy link
Collaborator Author

I would remove the tapping_features.R and move all of its content to get_tapping_features.R. If needed we can add this later. For now, we keep this repo slim and less-redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants