Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename flip_vertically and flip_horizontally methods #945

Closed
lars-reimann opened this issue Nov 11, 2024 · 1 comment · Fixed by #946
Closed

Rename flip_vertically and flip_horizontally methods #945

lars-reimann opened this issue Nov 11, 2024 · 1 comment · Fixed by #946
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

Image and ImageList have the methods flip_vertically and flip_horizontally. The names can be slightly confusing, though, as flip_vertically flips images along a horizontal axis and flip_horizontally flips them along a vertical axis.

Desired solution

Rename

  • flip_vertically to flip_top_and_bottom
  • flip_horizontally to flip_left_and_right.

This makes it completely clear how the image is transformed.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Nov 11, 2024
@lars-reimann lars-reimann linked a pull request Nov 20, 2024 that will close this issue
feat: rename flip_vertically and flip_horizontally methods #946
Merged
@lars-reimann lars-reimann mentioned this issue Nov 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Nov 20, 2024
lars-reimann pushed a commit that referenced this issue Nov 26, 2024
@semantic-release-bot
chore(release): 0.29.0 [skip ci]
8b71f9d 
## [0.29.0](v0.28.1...v0.29.0) (2024-11-26)

### Features

* remove `Image.__array__` ([#964](#964)) ([d2f59c9](d2f59c9))
* rename `count_row_if` to `count_rows_if` ([#960](#960)) ([f5d6324](f5d6324))
* rename `epoch_size` to `epoch_count` ([#962](#962)) ([fa62e9b](fa62e9b))
* rename `flip_vertically` and `flip_horizontally` methods ([#946](#946)) ([a3607d7](a3607d7)), closes [#945](#945)
* rename `load_pretrained_model` to `from_pretrained_model` ([#957](#957)) ([5b32acc](5b32acc))
* rename `Row.get_value` to `Row.get_cell` ([#947](#947)) ([e77cb6c](e77cb6c))

### Bug Fixes

* avoid performance warning when accessing `column_count` ([#949](#949)) ([c24b6d5](c24b6d5))
* handle deprecations in third-party libraries ([#963](#963)) ([e10e6bb](e10e6bb))
* index tensor on cpu ([#961](#961)) ([afafd43](afafd43))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename flip_vertically and flip_horizontally methods Safe-DS/Library
1 participant
@lars-reimann