Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make user specify positive_class to BaselineClassifier.predict #896

Open
sibre28 opened this issue Jul 10, 2024 · 1 comment
Open

Make user specify positive_class to BaselineClassifier.predict #896

sibre28 opened this issue Jul 10, 2024 · 1 comment
Labels
enhancement 💡 New feature or request

Comments

@sibre28
Copy link
Contributor

sibre28 commented Jul 10, 2024 •
edited
Loading

Is your feature request related to a problem?

The positive class for BaselineClassifier Metrics is always set as the first value of the target column.

Desired solution

Add a non-optional parameter positive_class to BaselineClassifier.predict that forces the user to specify the positive class.

Possible alternatives (optional)

Don't always calculate all metrics, let the User specify the metric. This would eliminate the need to define a positive class, when only needing a baseline accuracy.

Screenshots (optional)

No response

Additional Context (optional)

No response
@sibre28 sibre28 added the enhancement 💡 New feature or request label Jul 10, 2024
@sibre28 sibre28 changed the title Add parameter positive_class to BaselineClassifier.predict Make user specify positive_class to BaselineClassifier.predict Jul 10, 2024
@lars-reimann
Copy link
Member

Why is this needed for predict? How would this information affect the prediction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 💡 New feature or request
Projects
Library
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lars-reimann @sibre28