Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FNN Layer and Model Performance #610

Closed
sibre28 opened this issue Apr 4, 2024 · 1 comment · Fixed by #616
Closed

Improve FNN Layer and Model Performance #610

sibre28 opened this issue Apr 4, 2024 · 1 comment · Fixed by #616
Labels
performance 🏃 Speed things up released Included in a release

Comments

@sibre28
Copy link
Contributor

sibre28 commented Apr 4, 2024

Is your feature request related to a problem?

Currently our model is doing fine performancewise, since we just support FNN-Layers. But since we will also implement CNNs, which partly depend on FNN-Layers it is important for them to be performance-optimal, since small suboptimal implementations that don't really impact FNNs, will have a huge impact on computing time when working with Images.

Desired solution

Rework some code parts to optimize computing time and fix some bugs, everything discussed with @Marsmaennchen221

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@sibre28 sibre28 added the enhancement 💡 New feature or request label Apr 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 4, 2024
@sibre28 sibre28 changed the title Improve FNN Layer and Model Performance and remove some bugs Improve FNN Layer and Model Performance Apr 4, 2024
@Marsmaennchen221 Marsmaennchen221 added performance 🏃 Speed things up and removed enhancement 💡 New feature or request labels Apr 5, 2024
@sibre28 sibre28 mentioned this issue Apr 9, 2024
Merged
@sibre28 sibre28 linked a pull request Apr 9, 2024 that will close this issue
perf: improve performance of model & forward layer #616
Merged
Marsmaennchen221 added a commit that referenced this issue Apr 17, 2024
@sibre28 @Marsmaennchen221
@megalinter-bot @WinPlay02
perf: improve performance of model & forward layer (#616)
e856cd5 
Closes #610 

### Summary of Changes

Fixed some bugs and improved the performance of some methods, there are
still some changes to be made but it is helpful to merge this now as
@Marsmaennchen221 and @Gerhardsa0 partly depend on it

---------

Co-authored-by: Alexander Gréus <[email protected]>
Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: WinPlay02 <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Apr 17, 2024
lars-reimann pushed a commit that referenced this issue Apr 17, 2024
@semantic-release-bot
chore(release): 0.21.0 [skip ci]
e01ad89 
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17)

### Features

* add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570)
* Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600)
* more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a))

### Performance Improvements

* Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606)
* improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610)
* lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313))
* treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance 🏃 Speed things up released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: improve performance of model & forward layer Safe-DS/Library
3 participants
@lars-reimann @Marsmaennchen221 @sibre28