Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds checks for some Image methods #599

Closed
lars-reimann opened this issue Apr 1, 2024 · 0 comments · Fixed by #534
Closed

Bounds checks for some Image methods #599

lars-reimann opened this issue Apr 1, 2024 · 0 comments · Fixed by #534
Assignees
@Marsmaennchen221
Labels
enhancement 💡 New feature or request

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

Some parameters of Image methods have smaller legal ranges than their type suggests. This includes:

  • Image.resize (all parameters >= 0)
  • Image.crop (all parameters >= 0)
  • Image.blur (radius >= 0)

Desired solution

Raise OutOfBoundsError and add Raises sections to the docstrings.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 1, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 1, 2024
@Marsmaennchen221 Marsmaennchen221 self-assigned this Apr 5, 2024
Marsmaennchen221 added a commit that referenced this issue Apr 9, 2024
@Marsmaennchen221
docs: Added missing and fixed wrong docstrings #600
0db8a86 
feat: Added missing errors and warnings #599
fix: Fixed wrong indices in `ImageList.remove_images_with_size`
refactor: Moved transformation error and warning checks to utils file
@Marsmaennchen221 Marsmaennchen221 mentioned this issue Apr 9, 2024
Merged
@Marsmaennchen221 Marsmaennchen221 linked a pull request Apr 9, 2024 that will close this issue
feat: Add ImageList class #534
Merged
Marsmaennchen221 added a commit that referenced this issue Apr 10, 2024
@Marsmaennchen221 @megalinter-bot @WinPlay02
feat: Add ImageList class (#534)
3cb74a2 
Closes #528, #599, #600

### Summary of Changes

Added ImageList class.

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: WinPlay02 <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Apr 10, 2024
lars-reimann pushed a commit that referenced this issue Apr 17, 2024
@semantic-release-bot
chore(release): 0.21.0 [skip ci]
e01ad89 
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17)

### Features

* add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570)
* Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600)
* more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a))

### Performance Improvements

* Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606)
* improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610)
* lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313))
* treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marsmaennchen221 Marsmaennchen221

Labels
enhancement 💡 New feature or request
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ImageList class Safe-DS/Library
2 participants
@lars-reimann @Marsmaennchen221