Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fnn functionality #529

Merged
merged 78 commits into from
Mar 20, 2024
Merged

feat: add fnn functionality #529

merged 78 commits into from
Mar 20, 2024

Conversation

sibre28
Copy link
Contributor

@sibre28 sibre28 commented Jan 18, 2024

Closes #522

Summary of Changes

Added Model and layer classes to support Feed Forward Neural Network Functionality.
Added into_dataloader() Function in TaggedTable Class, that creates a pytorch dataloader for any given tagged table, which can then be used to train a FNN.
Tests for those modules are probably incomplete, as i wasnt really sure what to test for, could use some feedback there.

@sibre28 sibre28 requested a review from a team as a code owner January 18, 2024 12:50
@sibre28 sibre28 linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 18, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 9 0 0 1.05s
✅ PYTHON mypy 9 0 1.97s
✅ PYTHON ruff 9 0 0 0.17s
✅ REPOSITORY git_diff yes no 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca23f0f) to head (b07bd48).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #529    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           50        53     +3     
  Lines         2973      3198   +225     
==========================================
+ Hits          2973      3198   +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sibre28 sibre28 changed the title 522 add fnn functionality feat:522 add fnn functionality Jan 18, 2024
@sibre28 sibre28 changed the title feat:522 add fnn functionality feat: 522 add fnn functionality Jan 18, 2024
src/safeds/ml/nn/_fnn_layer.py Outdated Show resolved Hide resolved
src/safeds/ml/nn/_model.py Outdated Show resolved Hide resolved
src/safeds/ml/nn/_model.py Outdated Show resolved Hide resolved
@sibre28 sibre28 dismissed lars-reimann’s stale review March 10, 2024 10:34

Want to merge this and Lars isnt available to approve changes

@sibre28 sibre28 marked this pull request as ready for review March 19, 2024 15:19
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to make some adjustments later, but for now this is good to go.

@lars-reimann lars-reimann merged commit ce53153 into main Mar 20, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 522-add-fnn-functionality branch March 20, 2024 16:15
lars-reimann pushed a commit that referenced this pull request Apr 3, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03)

### Features

* add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7))
* add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522)
* add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee))
* added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519)
* added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549)
* when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571)

### Bug Fixes

* incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53))
* mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FNN-Functionality
5 participants