fix: type checking of two union types #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 92 92
Lines 17119 17121 +2
Branches 3549 3549
=========================================
+ Hits 17119 17121 +2 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Apr 1, 2024
## [0.9.0](v0.8.0...v0.9.0) (2024-04-01) ### Features * `unknown` default value of stub parameters ([#952](#952)) ([78103e3](78103e3)), closes [#951](#951) * `unknown` type ([#973](#973)) ([4638249](4638249)), closes [#967](#967) * add constraints to stubs ([#953](#953)) ([dc5bf3b](dc5bf3b)) * allow any widening/narrowing type cast ([#948](#948)) ([ce01628](ce01628)) * checking of parameter bounds ([#925](#925)) ([610604f](610604f)), closes [#18](#18) * Markdown documentation generator ([#963](#963)) ([77d04de](77d04de)), closes [#663](#663) * stubs for `safe-ds` library ([#950](#950)) ([155b1c0](155b1c0)), closes [#926](#926) * VS Code command to dump diagnostics into a JSON file ([#928](#928)) ([34fa884](34fa884)), closes [#927](#927) ### Bug Fixes * do not memoize calls containing lambdas calling segments ([#944](#944)) ([114fee6](114fee6)) * language server crash on startup ([#947](#947)) ([9923074](9923074)), closes [#945](#945) * type checking of two union types ([#949](#949)) ([21fc485](21fc485))
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The quantifiers were in the wrong order when checking whether two union types were subtypes of each other:
Previously,
isSubtypeOfonly returnedtrue, if there was one entry ofotherthat was a supertype of all entries oftype.Now, it returns
trueif for all entries oftypethere is one entry ofotherthat is a supertype.