Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error messages from linker #1272

Merged
merged 2 commits into from
Nov 24, 2024
Merged

feat: improve error messages from linker #1272

merged 2 commits into from
Nov 24, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 24, 2024 •
edited
Loading

Closes #1268

Summary of Changes

  • Improve default error message of the linker.
  • Add a default resolution to the message that might solve the issue (check spelling and imports).
  • Add special resolutions, if users likely used Python keywords instead of Safe-DS keywords by accident (e.g. True instead of true).

@lars-reimann lars-reimann linked an issue Nov 24, 2024 that may be closed by this pull request
Allow True/False/None in grammar? #1268
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.14s
✅ TYPESCRIPT eslint 3 0 0 4.44s
✅ TYPESCRIPT prettier 3 0 0 0.83s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (9b5e488) to head (171dfa3).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         112      113    +1     
  Lines       12828    12854   +26     
  Branches     4212     4220    +8     
=======================================
+ Hits        12797    12823   +26     
  Misses         31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@lars-reimann lars-reimann merged commit eddd868 into main Nov 24, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 1268-allow-truefalsenone-in-grammar branch November 24, 2024 18:29
lars-reimann pushed a commit that referenced this pull request Nov 24, 2024
@semantic-release-bot
chore(release): 0.22.0 [skip ci]
d30edbc 
## [0.22.0](v0.21.1...v0.22.0) (2024-11-24)

### Features

* categorize API elements ([#1263](#1263)) ([d0d971e](d0d971e)), closes [#1243](#1243)
* disable inlay hints for assignee types by default ([#1260](#1260)) ([a651ade](a651ade))
* improve error messages from linker ([#1272](#1272)) ([eddd868](eddd868)), closes [#1268](#1268)
* output statement ([#1262](#1262)) ([011ba31](011ba31)), closes [#1259](#1259)
* remove schema concept from grammar ([#1273](#1273)) ([1a3bf80](1a3bf80)), closes [#1133](#1133)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow True/False/None in grammar?
1 participant
@lars-reimann