From ffae98a1e4d5aae63942d1e794c898f401374915 Mon Sep 17 00:00:00 2001 From: Lars Reimann Date: Tue, 9 Apr 2024 14:07:48 +0200 Subject: [PATCH] fix: show EDA tool for `TaggedTable` and `TimeSeries` (#1017) ### Summary of Changes The EDA tool does it own additional type checking to ensure it only opens on `Table`s. This should be removed eventually and type checking should be fully delegated to the language server. For now, this PR also allows opening it on `TaggedTable` and `TimeSeries`. --- packages/safe-ds-vscode/src/extension/mainClient.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/safe-ds-vscode/src/extension/mainClient.ts b/packages/safe-ds-vscode/src/extension/mainClient.ts index c2e289e55..0166a2e9c 100644 --- a/packages/safe-ds-vscode/src/extension/mainClient.ts +++ b/packages/safe-ds-vscode/src/extension/mainClient.ts @@ -292,7 +292,10 @@ const runEda = function ( ); if ( message.id === pipelineExecutionId && - message.data.type === 'Table' && + // Can be removed altogether if the EDA tool is only triggered via code lenses + (message.data.type === 'Table' || + message.data.type === 'TaggedTable' || + message.data.type === 'TimeSeries') && message.data.name === requestedPlaceholderName ) { lastFinishedPipelineExecutionId = pipelineExecutionId;