Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance in RuntimeInputValidator #44

Open
sobolewskikamil opened this issue Jul 30, 2018 · 0 comments
Open

Improve performance in RuntimeInputValidator #44

sobolewskikamil opened this issue Jul 30, 2018 · 0 comments

Comments

@sobolewskikamil
Copy link
Collaborator

Problem description
RuntimeInputValidator is a class responsible for checking if context contains all facts required by the rule. Currently it works by resolving each fact using its identifier. This causes big overhead and drastically drops YARE's performance. We would like preserve this validation, but implement it using index based construction.

Suggested solution

  • Run performance tests (mvn clean install -Pperformance) and gather results
  • Implement new validation mechanism
  • Run performance tests again to check performance outcome

Acceptance criteria

  • Tests are prepared
  • Performance tests results are satisfying and published as a part of pull request
  • Code review is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant