From 8adaa6559fb7ebd411d36a43b36eb173ead9b94f Mon Sep 17 00:00:00 2001 From: "Saad A. Bazaz" Date: Fri, 4 Oct 2024 01:01:58 +0500 Subject: [PATCH] chore: clean stale comment --- crates/biome_js_analyze/src/lint/nursery/no_secrets.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/biome_js_analyze/src/lint/nursery/no_secrets.rs b/crates/biome_js_analyze/src/lint/nursery/no_secrets.rs index 48f0c82ea9e2..19466df162f1 100644 --- a/crates/biome_js_analyze/src/lint/nursery/no_secrets.rs +++ b/crates/biome_js_analyze/src/lint/nursery/no_secrets.rs @@ -133,7 +133,7 @@ impl Rule for NoSecrets { #[serde(rename_all = "camelCase", deny_unknown_fields)] pub struct NoSecretsOptions { /// Set entropy threshold (default is 41). - entropy_threshold: Option, // @TODO: Doesn't work currently. + entropy_threshold: Option, } fn is_path(text: &str) -> bool { @@ -349,7 +349,7 @@ fn detect_secret(data: &str, entropy_threshold: &u16) -> Option<&'static str> { println!("Token: {}, length: {}", token, token.len()); if token.len() >= MIN_PATTERN_LEN { - // Skip known safe patterns + if is_known_safe_pattern(token) { continue; }