Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of pod life-cycle during deployment #756

Merged
merged 3 commits into from
Mar 10, 2020

Conversation

KucharczykL
Copy link
Contributor

Closes #748.

@KucharczykL KucharczykL requested a review from btat March 9, 2020 13:50
@KucharczykL
Copy link
Contributor Author

I wasn't sure what amount of detail was desired so it might needs a bit of trimming. I didn't edit the second part of that entity (pods restarting).

@btat
Copy link
Collaborator

btat commented Mar 9, 2020

Looks good. I think we can comment out/remove the pod restarts one in a subsequent once we confirm it's no longer needed.

Forgot to include this in the original issue description, but can you update the scf-deploy-complete entity as well. It's used to describe how the pods and their status should look when the deployment is successful/complete.

@KucharczykL
Copy link
Contributor Author

I have updated the description to reflect the current result. I am not sure whether I should replace all instances of scf with kubecf. So far I have only edited the commands and pod names.

@btat
Copy link
Collaborator

btat commented Mar 10, 2020

Thanks for updating the other entity as well. I think it's fine if we leave the scf to kubecf change off this PR. We can make a separate PR to update that in all content.

@btat btat merged commit 8fdfb2f into master Mar 10, 2020
@btat btat deleted the deployment-pod-status branch March 10, 2020 17:36
@btat btat added the 2.0 Content should be added to 2.0 branch label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Content should be added to 2.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description of pod lifecycle during deployment
2 participants