jobs: fixed crono job when a repository could not be found

Fixes #720

Signed-off-by: Miquel Sabaté Solà <[email protected]>

app/jobs/catalog_job.rb

@@ -32,7 +32,7 @@ def update_registry!(catalog)
         Rails.logger.debug "skip upload not finished repo #{r["name"]}"
       else
         repository = Repository.create_or_update!(r)
-        dangling_repos.delete repository.id
+        dangling_repos.delete repository.id unless repository.nil?
       end
     end
 

spec/jobs/catalog_job_spec.rb

@@ -67,6 +67,24 @@ def update_registry!(catalog)
       tags = repo.tags
       expect(tags.map(&:name)).to match_array(["latest"])
     end
+
+    it "handles registries even if there some namespaces missing" do
+      registry = create(:registry, "hostname" => "registry.test.lan")
+
+      VCR.use_cassette("registry/get_registry_catalog_namespace_missing", record: :none) do
+        job = CatalogJobMock.new
+        job.perform
+      end
+
+      repos = Repository.all
+      expect(repos.count).to be 1
+      repo = repos[0]
+      expect(repo.name).to eq "busybox"
+      expect(repo.namespace.id).to eq registry.namespaces.first.id
+      tags = repo.tags
+      expect(tags.map(&:name)).to match_array(["latest"])
+    end
+
   end
 
   describe "Database already filled with repos" do