NoJira: NextJS Runtime Plugin 5.2 Compatibility

[sherakama]

READY FOR REVIEW

Summary

• Messing with the function includes to add the .env file breaks the builds with @netlify/plugin-nextjs version 5.2
• This change removes the addition of that rule and also removes the removing of the .env file from the build as the neltify plugin does the cleanup for us.

Review By (Date)

• EOW of the week of May 6

Steps to test

• Pull this branch into your build.
• Ensure build still builds
• Ensure SSR works
• Ensure API's still have the env var values

Resources

• Reproduction repo: https://github.com/SU-SWS/envfile-unlink-bug/tree/main
• Test existing build: GIVCAMP-314: Upgrade to Next 14.2 ood-giving-campaign#270
• My Account Testing build: https://github.com/SU-SWS/adapt-my-account/pull/1212

[ericbakenhus]

@sherakama Dropping this into MA with no other changes and clearing the Netlify build cache results in a successful build and a (seemingly) working app. 👍

If I bump Next.js up to version 13.5 it builds, but things start to break. Might not be related, but I'm still looking into it. 🤷

[sherakama]

If I bump Next.js up to version 13.5 it builds, but things start to break. Might not be related, but I'm still looking into it. 🤷

Possibly that the .env file is missing from some functions?

[stfurkan]

If I bump Next.js up to version 13.5 it builds, but things start to break. Might not be related, but I'm still looking into it. 🤷

Possibly that the .env file is missing from some functions?

@sherakama @ericbakenhus It works with [email protected] for https://next-give.netlify.app

[ericbakenhus]

If I bump Next.js up to version 13.5 it builds, but things start to break. Might not be related, but I'm still looking into it. 🤷

Possibly that the .env file is missing from some functions?

Yeah, that sounds about right. 😭

[sherakama]

If I bump Next.js up to version 13.5 it builds, but things start to break. Might not be related, but I'm still looking into it. 🤷

Possibly that the .env file is missing from some functions?

Yeah, that sounds about right. 😭

I created a test build at https://github.com/SU-SWS/adapt-my-account/pull/1212 to see if the variables are showing up and it looks like they do with the exception of the edge function but that is a known thing.

I'm going to add the versions as peerDependencies and roll this as a major release.

[sherakama]

Assuming forward compatibility after these versions.

[sherakama]

Added as peerDependencies and set the meta to optional so the package manager doesn't get angry.

[sherakama]

Thanks for all the testing and feedback everyone. Moving forward with this version.