Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename on execution::schedule_from, rename just_on to just_transfer, and add transfer #5656

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

msimberg
Copy link
Contributor

Continues from #5644.

@msimberg msimberg added the category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals label Nov 16, 2021
@msimberg msimberg added this to the 1.8.0 milestone Nov 16, 2021
@msimberg msimberg added the split: local PR targets local functionality label Nov 17, 2021
hkaiser
hkaiser previously approved these changes Nov 17, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Nov 17, 2021

This can go in once the missing replacings have been done.

aurianer
aurianer previously approved these changes Nov 18, 2021
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg dismissed stale reviews from aurianer and hkaiser via 16424ac November 18, 2021 09:49
@msimberg msimberg force-pushed the rename-on-just_on branch 3 times, most recently from 52a21a0 to 147248d Compare November 18, 2021 13:11
@msimberg
Copy link
Contributor Author

retest cscs

@albestro albestro mentioned this pull request Nov 23, 2021
7 tasks
@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented Nov 25, 2021

👎 Rejected by too few approved reviews

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented Nov 25, 2021

👎 Rejected by too few approved reviews

@msimberg msimberg merged commit 8de8d18 into STEllAR-GROUP:master Nov 25, 2021
@msimberg msimberg deleted the rename-on-just_on branch November 25, 2021 10:23
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Nov 25, 2021
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 1, 2021
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 6, 2021
albestro added a commit to eth-cscs/DLA-Future that referenced this pull request Dec 9, 2021
msimberg pushed a commit to msimberg/DLA-Future that referenced this pull request Jan 21, 2022
msimberg pushed a commit to eth-cscs/DLA-Future that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals split: local PR targets local functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants